gRIBI: Validate ARP between DUT and OTG before gRIBI programming

[dracazacula]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the gRIBI full-scale test suite by ensuring comprehensive ARP validation across all configured interfaces. By removing the previous artificial limit on interface checks and properly tracking sub-interface names, the test suite now provides more robust verification before proceeding with gRIBI programming.

Highlights

• Interface tracking: Updated the ConfigureOTG function to correctly capture and return sub-interface names for port 2.
• ARP validation: Removed the 100-interface limit for ARP resolution checks, ensuring all interfaces in the full-scale test are validated for both IPv4 and IPv6.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5822 / 34330e6

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request updates ConfigureOTG to append port 2 sub-interfaces to the interface names list, and removes the 100-interface limit when validating ARP resolution in RunFullScaleTest. The reviewer correctly flags that verifying ARP resolution sequentially for all interfaces is a performance anti-pattern that will slow down test execution. They recommend optimizing the validation logic by using batch operations, such as fetching the state of all interfaces in a single gNMI query.

[navaneethyv]

@dracazacula can you share the delta time increase due to this check ?

[dracazacula]

@dracazacula can you share the delta time increase due to this check ?

@navaneethyv I don't have a relevant comparison because the test was waiting for only 1 interface vs now 641, but in my last (Nokia) run it takes around 12-14m for both ipv4 and v6 to be validated.

This change is required though because if the gRIBI programming is started without waiting, some NHs may point to some sub-interfaces which may not point yet to a valid destination and programming fails.

I am not sure the waiting time is a super big issue, since this is a scale test with heavy programming, heavy traffic, multiple scenarios, so already big.