Hide internal platform tip kinds from profile transactions by default - #12345
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughTransaction query variable builders now receive host status. Estimated code review effort: 3 (Moderate) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/collective-page/sections/Budget.js`:
- Line 238: Update the budget query-variable flow to use the explicit
collective.isHost value when determining transaction kinds, rather than
comparing host?.slug with collectiveSlug. Add or pass this flag through
getBudgetSectionQueryVariables and update all its callers, preserving the
existing getDefaultKinds behavior for non-host profiles.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e71946bb-95a8-4ecb-995d-51e51e7f0ea7
📒 Files selected for processing (4)
components/collective-page/graphql/preload.jscomponents/collective-page/sections/Budget.jscomponents/collective-page/sections/Transactions.jscomponents/transactions/filters/TransactionsKindFilter.js
4ff4d8c to
f1e17f7
Compare
APPLICATION_FEE is removed from the default kinds: it only ever appears on host-side accounts as the internal fee leg moving collected tips to the platform. PLATFORM_TIP is now excluded from the defaults on fiscal host profiles only, where the rows are tips collected on the internal Platform Tips child account rather than host activity. Contributors (individuals and organizations) still see the tips they gave. Both kinds remain available through the kind filter on the transactions page. Dashboard views and exports are unchanged.
f1e17f7 to
d15b71a
Compare
1 participant
On fiscal host profiles (like @opensource), the transactions and budget sections currently show the platform tips collected on the internal Platform Tips child account, along with the APPLICATION_FEE legs that move that money to the platform. These are internal billing flows between the host and the platform, not host activity, so I'm removing them from the default view.
APPLICATION_FEE is removed from the default kinds everywhere, since it only ever appears on host-side accounts. PLATFORM_TIP is excluded from the defaults only when the profile is a fiscal host: contributors (individuals and organizations) still see the tips they gave, which are part of their own financial activity.
Both kinds remain available through the kind filter on the transactions page. Dashboard views, exports and the API are unchanged.