Skip to content

Fix basic auth parsing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdowler merged 3 commits into from
Dec 11, 2025
Merged

Fix basic auth parsing #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5459677
Fixed user/passwd parsing
Nov 24, 2025
9b371ec
Small change
Nov 24, 2025
925b684
Changes after code review
Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cred/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## deployable containers have a semantic and build tag
# semantic version tag: major.minor
# build version tag: timestamp
VER=2.0.2
VER=2.0.3
TAGS="${VER} ${VER}-$(date -u +"%Y%m%dT%H%M%S")"
unset VER
9 changes: 6 additions & 3 deletions cred/src/main/java/org/opencadc/cred/BasicAuthIdentityManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,12 @@ public Subject validate(Subject subject) throws AccessControlException {
Base64.Decoder dec = Base64.getDecoder();
byte[] b = dec.decode(ss[1]);
String creds = new String(b); // default charset
String[] up = creds.split(":");
username = up[0];
password = up[1];
int colonIndex = creds.indexOf(":");
if (colonIndex < 1) {
throw new NotAuthenticatedException("Incorrect user/password input in basic auth challenge");
}
username = creds.substring(0, colonIndex);
password = creds.substring(colonIndex + 1);
}
if (username != null && password != null) {
LocalAuthority loc = new LocalAuthority();
Expand Down