Skip to content

Get aws login working and documented [stage 1] - #579

Draft
ianheggie-oaf wants to merge 7 commits into
mainfrom
feature/558-aws-login
Draft

Get aws login working and documented [stage 1]#579
ianheggie-oaf wants to merge 7 commits into
mainfrom
feature/558-aws-login

Conversation

@ianheggie-oaf

@ianheggie-oaf ianheggie-oaf commented Jul 18, 2026

Copy link
Copy Markdown
Member

Description

Use aws login which opens a browser session to authenticate with aws console login credentials including MFA where configured.
This replaces aws configure and/or env variables with long lived access keys. Instead temporary credentials (typically 12 hours) are generated.
Using aws sso login is also deprecated because it is more complicated to setup per user.

Related changes:

  1. Checks that aws is recent enough to support aws login command
  2. Checks that the session-manager-plugin is installed so SSM sessions are available where SSM is configured on the server, eg:
aws ssm start-session --target i-04885b2749bc99213
  1. Documented how to setup ~/.aws/config so terraform can recognise the new credentials process

Motivation and Context

  • To enable the use of MFA for authentication

  • To reduce the number of different credentials and IAM users needed

  • Making sure the required tools are installed to support:

  • IAM Users no longer need to have long lived access keys. It is suggested they be disabled first to confirm nothing breaks and later removed.

How Has This Been Tested?

Checked it detected my old aws version (make aws-check prints a messages and exits with status 1)

  • Checked affected area manually on my own / staging system
    Developed and tested on Ubuntu 24.04.4 LTS x86_64 with ruby installed by mise, mysql 8.0, redis 5:7.0, make 4.3

  • Ran automated tests on my own system

    • make lint,
    • make aws-check
    • make requirements
    • make
    • make check-righttoknow STAGE=staging # for ansible
    • make tf-plan for terraform
  • Confirmed it passed the GitHub actions tests

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ianheggie-oaf ianheggie-oaf self-assigned this Jul 18, 2026
@ianheggie-oaf
ianheggie-oaf marked this pull request as ready for review July 18, 2026 12:14
@ianheggie-oaf
ianheggie-oaf requested a review from a team as a code owner July 18, 2026 12:14
@ianheggie-oaf
ianheggie-oaf enabled auto-merge July 18, 2026 12:14
Comment thread Makefile
@ianheggie-oaf ianheggie-oaf changed the title Check aws is recent enough that aws login can be used Check aws is recent enough that aws login can be used [stage 1] Jul 18, 2026
@ianheggie-oaf ianheggie-oaf changed the title Check aws is recent enough that aws login can be used [stage 1] Check aws is recent enough and ssm plugin installed [stage 1] Jul 18, 2026
@ianheggie-oaf ianheggie-oaf changed the title Check aws is recent enough and ssm plugin installed [stage 1] Get aws login working and documented [stage 1] Jul 18, 2026

@benrfairless benrfairless left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add MacOS Install instructions pls :)

Comment thread Makefile
@ianheggie-oaf
ianheggie-oaf force-pushed the feature/558-aws-login branch from 96adf4c to f29cddd Compare July 20, 2026 11:48
Add brew instruction for session manager

Co-authored-by: Ben Fairless <ben@oaf.org.au>
@ianheggie-oaf
ianheggie-oaf marked this pull request as draft July 20, 2026 14:36
auto-merge was automatically disabled July 20, 2026 14:36

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants