exec-server: trace terminal RPC notifications#31730
Closed
anp-oai wants to merge 2 commits into
Closed
Conversation
This was referenced Jul 9, 2026
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
force-pushed
the
codex/exec-server-notification-trace-carrier
branch
from
d6f14a8 to
54fec74
Compare
anp-oai
force-pushed
the
codex/exec-server-notification-receive-spans
branch
from
6de06f0 to
a9f4788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make terminal server-to-client lifecycle handling visible in the originating distributed trace without exporting a span for every output or body chunk.
What
process/exited,process/closed, and terminal or errorhttp/request/bodyDeltanotifications.process/outputand nonterminal body deltas span-free while accepting the universal notification carriers provided by the parent PR.Manual validation
just test -p codex-exec-server— 309 passed, 2 skipped.Stack