[codex-apps] Filter optional file fields by tool schema#31686
Open
tsarlandie-oai wants to merge 2 commits into
Open
[codex-apps] Filter optional file fields by tool schema#31686tsarlandie-oai wants to merge 2 commits into
tsarlandie-oai wants to merge 2 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b32fb3fd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex Apps file parameters are exposed to the model as local paths, uploaded at execution time, and rewritten into provided-file payloads before the MCP tool call.
The rewrite currently includes the documented optional fields
mime_typeandfile_namefor every file parameter. Apps with strict schemas can reject those fields when they are not declared.Changes
openai/fileParamsparameter's raw input schema before replacing it with the model-visible local-path schema.download_urlandfile_id.mime_typeandfile_nameonly when that specific file parameter's schema accepts them, including schemas that allow additional properties.This supports tools with different file contracts in the same app: one parameter can accept the optional fields while another remains strict.
Validation
just test -p codex-mcpjust test -p codex-core mcp_openai_filejust test -p codex-core codex_apps_file_params_just fix -p codex-mcpjust fix -p codex-corejust fmtgit diff --checkdownload_urlandfile_idmime_typeandfile_nameRelated: #31330