-
Notifications
You must be signed in to change notification settings - Fork 14.4k
core: allow restricting subagent environments #31662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
frantic-openai
wants to merge
4
commits into
main
Choose a base branch
from
codex/subagent-environment-ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6809c8b
core: allow restricting subagent environments
frantic-openai 82e8236
codex: fix CI failure on PR #31662
frantic-openai 57cdf8b
codex: fix CI failure on PR #31662
frantic-openai e708ed6
fix: preserve restricted subagent environments
frantic-openai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,6 +118,8 @@ async fn handle_spawn_agent( | |
| ) | ||
| .await?; | ||
| apply_spawn_agent_runtime_overrides(&mut config, turn.as_ref())?; | ||
| let environments = | ||
| spawn_agent_environment_selections(turn.as_ref(), args.environment_ids.as_deref())?; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we validate environment_ids before emitting the v1 |
||
|
|
||
| let result = Box::pin(session.services.agent_control.spawn_agent_with_metadata( | ||
| config, | ||
|
|
@@ -133,7 +135,8 @@ async fn handle_spawn_agent( | |
| fork_parent_spawn_call_id: args.fork_context.then(|| call_id.clone()), | ||
| fork_mode: args.fork_context.then_some(SpawnAgentForkMode::FullHistory), | ||
| parent_thread_id: Some(session.thread_id), | ||
| environments: Some(turn.environments.to_selections()), | ||
| environments: Some(environments), | ||
| restricted_environment_ids: args.environment_ids.clone(), | ||
| }, | ||
| )) | ||
| .await | ||
|
|
@@ -236,6 +239,7 @@ struct SpawnAgentArgs { | |
| model: Option<String>, | ||
| reasoning_effort: Option<ReasoningEffort>, | ||
| service_tier: Option<String>, | ||
| environment_ids: Option<Vec<String>>, | ||
| #[serde(default)] | ||
| fork_context: bool, | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we cover this through an actual child model step? This assertion checks the stored vector, but not that fork-retained skills/MCP context from the omitted environment disappears from the outbound child request