Instrument device auth requests with client identity#31649
Open
etraut-openai wants to merge 4 commits into
Open
Instrument device auth requests with client identity#31649etraut-openai wants to merge 4 commits into
etraut-openai wants to merge 4 commits into
Conversation
Problem: Device authorization requests omitted Codex client identity metadata, limiting detection and investigation of third-party device-flow reuse. Solution: Send the existing originator, User-Agent, and trusted-path installation ID on both device-auth endpoints while withholding the durable ID from custom issuers. Manually verified production user-code issuance and repeated token polling with an isolated CODEX_HOME, then cancelled before authorization with no tokens persisted.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57e5d11f52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Device authorization requests currently omit Codex client identity metadata, which limits detection and investigation of third-party reuse of the device flow. This metadata is telemetry only and remains spoofable; it is not used to authorize or deny requests.
What changed
originatorand CodexUser-Agenton both device-auth endpoints.x-codex-installation-idfor the trusted issuer path.Verification
Manually exercised the production device flow with an isolated temporary
CODEX_HOME. The user-code endpoint issued a code, token polling continued across multiple intervals without rejecting the added headers, and the flow was cancelled before authorization with no tokens persisted.