Avoid no-op recency migration repair writes#31638
Draft
zanie-oai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #26420, avoid acquiring SQLite's writer slot when the legacy recency-migration repair has nothing to do. The repair now checks the applied migration history with a read-only query and only issues the guarded update for the exact legacy version-38/checksum state. This prevents normal state-runtime startup from waiting behind an unrelated writer while preserving the compatibility repair.
Includes regression coverage with a competing
BEGIN IMMEDIATEwriter.just test -p codex-statepasses all 153 tests;just fix -p codex-stateandjust fmtalso pass.