Skip to content

[personality] support harness-only personality none#31631

Draft
rhan-oai wants to merge 1 commit into
mainfrom
rhan/personality-none
Draft

[personality] support harness-only personality none#31631
rhan-oai wants to merge 1 commit into
mainfrom
rhan/personality-none

Conversation

@rhan-oai

@rhan-oai rhan-oai commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Why

The no-personality harness mode previously only worked through the legacy {{ personality }} template. Model prompts that bake personality guidance into a # Personality section need source-aware post-processing instead.

Only catalog-provided instructions are eligible for stripping. Explicit instructions remain authoritative, and the integration test verifies that a custom prompt containing # Personality reaches the outbound request byte-for-byte unchanged.

What changed

  • post-process catalog-provided model instructions only for explicit Some(Personality::None)
  • remove the first exact # Personality section through, but not including, the next H1
  • preserve explicit base-instruction overrides, resumed prompts, additive developer instructions, and existing Friendly/Pragmatic behavior
  • treat missing personality metadata as a valid fallback for Personality::None without emitting the named-personality warning
  • add table-driven models-manager coverage and focused outbound core integration coverage

Testing

  • just test -p codex-models-manager
  • just test -p codex-protocol
  • just test -p codex-core config_personality_none_
  • locally validated for 5.6 sol

@rhan-oai rhan-oai force-pushed the rhan/personality-none branch 5 times, most recently from 3985416 to 0c625ba Compare July 8, 2026 20:59
@rhan-oai rhan-oai force-pushed the rhan/personality-none branch from 0c625ba to f469f0b Compare July 8, 2026 21:19
@rhan-oai rhan-oai changed the title Support harness-only personality none [personality] support harness-only personality none Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants