Skip to content

[SDK] Fix lost wakeup in BatchLogProcessor shutdown/force-flush notify - #4518

Open
denizariyan wants to merge 2 commits into
open-telemetry:mainfrom
denizariyan:fix/batch-log-processor-wakeup
Open

[SDK] Fix lost wakeup in BatchLogProcessor shutdown/force-flush notify#4518
denizariyan wants to merge 2 commits into
open-telemetry:mainfrom
denizariyan:fix/batch-log-processor-wakeup

Conversation

@denizariyan

@denizariyan denizariyan commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #4400

Changes

  • Fix a notify without lock pattern that leads to lost wake ups leading to stalls. See linked issue for details
  • Add stress test to confirm the issue does not occur after the fix

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (bcd4f2d) to head (6812ca2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4518      +/-   ##
==========================================
+ Coverage   83.47%   83.48%   +0.01%     
==========================================
  Files         521      521              
  Lines       20380    20387       +7     
==========================================
+ Hits        17011    17018       +7     
  Misses       3369     3369              
Files with missing lines Coverage Δ
sdk/src/logs/batch_log_record_processor.cc 87.90% <100.00%> (+0.47%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denizariyan
denizariyan force-pushed the fix/batch-log-processor-wakeup branch from 7bca7b7 to 58fc587 Compare September 2, 2026 14:41
@denizariyan
denizariyan marked this pull request as ready for review September 2, 2026 17:47
@denizariyan
denizariyan requested a review from a team as a code owner September 2, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BatchLogRecordProcessor: lost condvar wakeup can stall Shutdown/ForceFlush by up to one schedule_delay

1 participant