Skip to content

[CODE HEALTH] Resolve multiple clang tidy warnings - #4492

Merged
marcalff merged 22 commits into
open-telemetry:mainfrom
dbarker:fix_multiple_clang_tidy_warnings
Aug 31, 2026
Merged

[CODE HEALTH] Resolve multiple clang tidy warnings#4492
marcalff merged 22 commits into
open-telemetry:mainfrom
dbarker:fix_multiple_clang_tidy_warnings

Conversation

@dbarker

@dbarker dbarker commented Aug 27, 2026

Copy link
Copy Markdown
Member

Contributes to #2053

Changes

resolves the following warnings:

  • modernize-use-using - 8 warnings
  • cppcoreguidelines-use-enum-class - 7 warnings
  • bugprone-random-generator-seed - 5 warnings
  • modernize-deprecated-headers - 4 warnings
  • misc-predictable-rand - 3 warnings
  • bugprone-derived-method-shadowing-base-method - 3 warnings
  • bugprone-unintended-char-ostream-output - 2 warnings
  • performance-move-const-arg - 2 warnings
  • cppcoreguidelines-macro-to-enum - 2 warnings
  • abseil-string-find-startswith - 1 warning
  • misc-use-internal-linkage - 1 warning

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker changed the title [CODE HEALTH] Fix multiple clang tidy warnings [CODE HEALTH] Resolve multiple clang tidy warnings Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (e68171d) to head (1f41589).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4492      +/-   ##
==========================================
+ Coverage   83.24%   83.25%   +0.01%     
==========================================
  Files         521      521              
  Lines       20384    20384              
==========================================
+ Hits        16967    16969       +2     
+ Misses       3417     3415       -2     
Files with missing lines Coverage Δ
api/include/opentelemetry/nostd/string_view.h 98.28% <ø> (ø)
...nclude/opentelemetry/ext/http/server/http_server.h 66.67% <ø> (ø)
...clude/opentelemetry/ext/http/server/socket_tools.h 95.68% <ø> (ø)
...include/opentelemetry/sdk/common/attribute_utils.h 95.63% <ø> (ø)
...pentelemetry/sdk/metrics/exemplar/reservoir_cell.h 97.83% <ø> (ø)
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 84.94% <100.00%> (ø)
...ntelemetry/sdk/metrics/view/attributes_processor.h 92.11% <ø> (ø)
sdk/src/resource/resource_detector.cc 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
dbarker marked this pull request as ready for review August 27, 2026 21:56
@dbarker
dbarker requested a review from a team as a code owner August 27, 2026 21:56

@denizariyan denizariyan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

Comment thread api/include/opentelemetry/version.h
Comment thread sdk/test/metrics/base2_exponential_histogram_indexer_benchmark.cc Outdated
Comment thread resource_detectors/test/service_detector_utils_test.cc

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

See suggestions from @denizariyan on fixed seeds in benchmarks.

@marcalff
marcalff merged commit 70fdb76 into open-telemetry:main Aug 31, 2026
76 of 77 checks passed
@dbarker
dbarker deleted the fix_multiple_clang_tidy_warnings branch August 31, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants