first step to support UTF-8 by accepting characters in the upper half of 8bit - #16
Open
RREE wants to merge 1 commit into
Open
first step to support UTF-8 by accepting characters in the upper half of 8bit#16RREE wants to merge 1 commit into
RREE wants to merge 1 commit into
Conversation
…haracters in the upper half of 8bits; 2 test cases
Contributor
Author
|
All builds on Linux and Windows stop with the same error: I don't know how to fix that. It does not stem from my pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to comment out
No_Implementation_Extensionsin order to keep the SPARK_Mode aspects.The check for control characters in
Read_Stringinhibited the reading of UTF-8 start bytes which all have the most significant bit set. Without that check we can read at least standard encoded UTF-8 string. This way I can handle German umlauts and sharp s.I still did not cover
\uencoded strings. Is probably difficult as we have to add string to UTF-8 conversion in the json library.