This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Don't trigger an update when moving cursor after saving - #2422
Closed
cbosdo wants to merge 1 commit into
Closed
Conversation
When saving a buffer neovim increments b:changedtick, which causes the buffer to be refreshed. To avoid this, update b:last_change_tick on BufWritePost events. Fixes issue onivim#2421
Contributor
Author
|
I figured out that the following scenario is still broken with linters that only work on saved files:
In such a case we would need to tell apart didOpen on saved files and those on dirty files. |
Member
|
@cbosdo thanks for the PR 👍 I think its worth noting that #2330 changes the changed tick functionality (removes it actually) and instead uses the new neovim updates api so it might be worth keeping that in mind as its possible that once that comes in the changes here might no longer apply or might need to be reworked to work with the new setup |
Contributor
Author
Contributor
Author
|
I don't have time to come back to this PR, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving a buffer neovim increments b:changedtick, which causes the
buffer to be refreshed. To avoid this, update b:last_change_tick on
BufWritePost events. Fixes issue #2421