Repository navigation
feat(ui): name the workspace on every session row and header (OH-77) - #23
Merged
Merged
Conversation
Resolve one identity label at the session workspace presentation owner: explicit workspace label, then the stored repository association name, then the directory's final segment. Rows and the detail header read that value, so a worktree shows its repository and the label stays a name in every path display mode. Rows paint it in the title row identity group in every density and grouping, unless the path line already carries it. Extract the machine identity hover into a shared anchor for the full name on hover and keyboard focus.
…ctly (OH-77) Review fixes for the session workspace label: - An association without a remote identity names only the checkout that was discovered first, so a sibling checkout keeps its own directory name unless the user chose a repository for it. - A repository group the user named is shown as typed, slashes included. - Extract the per-Home account read into useServerAccountScopes and use it in every grouping, so rows and the header resolve a foreign Home's stored association under that Home's account. The active Home is answered synchronously and starts no read. - Cap the header identity anchor at its column width so web truncation holds, and cover long names at narrow widths in the browser spec.
andorcassian
marked this pull request as ready for review
November 4, 2026 18:14
…project-label # Conflicts: # apps/ui/sources/components/sessions/shell/SessionItem.tsx
…project-label # Conflicts: # apps/ui/sources/components/sessions/SessionMachineIdentity.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Every session row and the session detail header now name the session's workspace, in every grouping and density.
resolveSessionWorkspacePresentationgainsidentityLabel. Rows, through the reachability display, and the header, throughuseSessionWorkspacePresentation, both read it.SessionIdentityHoverAnchoris extracted fromSessionMachineIdentityand shared by the row label, the path line and the header subtitle. Focus opens the tooltip only for keyboard focus, so clicking a row does not pin it. This also applies to the machine identity.Decisions taken:
ProjectGroupHeader.useServerAccountScopes, extracted from the Repository view, reads each foreign Home's account from local credentials in every grouping, and rows and the header both use it. Until that read lands, a foreign session shows its custom label or directory name. The active Home is answered synchronously and starts no read. This never starts SCM or RPC work. A side effect: group-order writes for a foreign Home now carry its account id in every grouping, not only in Repository and flat views.Validation
Run on the branch's last commit before
devwas merged in, unless noted. Hosted CI passed every lane on that commit, including the four UI E2E shards.identityLabelvalues and absent label nodes.generated-16instead ofgenerated-17);Client/Webshowed asWeb; foreign Home rows, header and the scope hook had no account outside Repository mode; the header anchor overflowed its column on web (992px right edge in a 717px column); and the header re-rendered once more for the active Home after the account read settled.sessionMachineTarget, the session model hooks, reachability, view state,SessionView,SessionItem,SessionsList, the row model,ChatHeaderView, the hover anchor andSessionMachineIdentity.sessionList.repositoryView.spec.ts, full file in Chrome, 3 passed. The new test checks a long name truncated inside its column on the row at 820px and on the header at 820px and 390px, with the full name in the tooltip. The 390px screenshot was inspected.apps/uitypecheck and tests package typecheck: both exit 0.devtwice: the first merge brought in OH-54, and its one conflict was the row accessible label, which now keeps both the workspace name and the machine name that OH-54 always includes. The second brought in OH-47, and its one conflict wasSessionMachineIdentity, which now keeps this change's shared hover anchor together with OH-47'ssubtitlevariant and per-variant styles. After the second merge, 20 test files passed (261 tests):SessionMachineIdentity, the hover anchor, everySessionItemfile,ProjectGroupHeader,SessionsListnative virtualization andChatHeaderView. Theapps/uitypecheck exits 0. Hosted CI on the final head passed every lane after one rerun of UI Unit Tests part 2, whose only failure wasModelPickerOverlay.test.tsx, a file outside this change that passes locally on the same head. Hosted CI on the first merge head passed every lane after one rerun of Production Build Smoke, whose runner ran out of disk while setting up Node.newSession.resumeId.browseFill.spec.tstiming out after picking a machine in/new. That flow is outside this change, and the same test also fails on another open PR.The spec's worktree test was already broken: it clicked
session-list-ordering-menu-trigger, which no longer exists in the UI. It now usessession-list-group-menu-trigger, the same as the rest of the file.Scope and deferrals
Tracks OH-77.