Skip to content

feat(ui): show the chosen machine glyph on project machine subtitles (OH-47) - #19

Merged
andorcassian merged 2 commits into
devfrom
feature/OH-47-project-header-machine-glyph
Nov 4, 2026
Merged

andorcassian merged 2 commits into
devfrom
feature/OH-47-project-header-machine-glyph

Conversation

@andorcassian

@andorcassian andorcassian commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

What changes

Project headers named their machine as plain text, so a machine's chosen icon and color never appeared on that surface. Repository checkout menus had the same gap.

  • ProjectGroupHeader now renders the shared SessionMachineIdentity, in a new subtitle variant that keeps the header's text size, color and width. The icon and color follow the same preference owner as rows and machine-group headers, and the glyph updates live when the preference changes.
  • Repository checkout menus (New session, Add folder, Associate) show each machine's glyph, so checkouts with the same label and path stay distinct.
  • The project header's accessibility label now includes the machine name whenever a machine is shown, including glyph-only headers.
  • The glyph uses item.machine.id, the machine the subtitle names, so the label and icon cannot disagree. This also covers a header with no workspaceScopeHint.
  • The Home comes from the same scope expression the header's favicon already uses, now shared as one value, so the same machine ID on two Homes stays distinct.
  • The synthetic unknown machine stays text-only, filtered through the existing normalizeKnownProjectMachineId, so it shows nothing when names are hidden. Single-machine lists show no glyph.
  • Adds the session-list-project-machine:<groupKey> testID on the subtitle row.
  • Updates the OH-47 note in docs/fork-development.md.

Decision recorded: Settings > Session > Machine names hides only the name on project headers. The glyph stays, with the name in its tooltip and accessibility text, because the ticket wants the icon and color to identify a machine when its label is hidden. Turning off "Machine on session rows" as well removes the glyph, so there is still a way to hide it. With names on, the name shows regardless of that row setting, as before.

Decision recorded: triage suggested workspaceScopeHint.machineId. I used item.machine.id because the hint is null without a server or path, and it is routing data rather than the subtitle's identity. Both producers set them to the same machine whenever both exist.

Validation

  • RED: new owner test in SessionsList.nativeVirtualization.test.tsx failed with expected [] to deeply equal [ ObjectContaining{ name: 'laptop' } ], because the header rendered no glyph.

  • GREEN: the same test passes. It covers per-Home icon and color, a missing scope hint, the unknown machine, the single-machine list, glyph-only headers, both machine settings off, and the accessibility label.

  • Review follow-up RED: the accessibility label failed with expected '/repo' to be '/repo, Studio', and the new repository menu test failed with expected [] to deeply equal [ 'laptop', 'cloud' ]. The glyph-only case was shown real by removing the fix: expected [] to deeply equal [ ObjectContaining{…} ]. All three pass now.

  • List wiring: a new test mounts the full SessionsList and checks that turning off "Machine on session rows" reaches the mounted project header. Replacing the wired setting with a constant fails it with expected true to be false.

  • Touched owner tests on this head: SessionsList*, SessionMachineIdentity.test.tsx and ChatHeaderView, 15 files, 236/236 pass. On this heavily loaded machine, the folder suite's first test hit the 60 s per-test limit in two earlier runs, and every later test in that file then failed on the unmounted renderer. The same file passed 41/41 with a longer limit, and then the whole set passed at the default limit. No timeout was changed in the repository.

  • apps/ui typecheck and @happier-dev/tests typecheck pass.

  • Browser (Chrome, web export): the full sessionList.orderingMode.spec.ts passes 7/7 on this head. Its project glyph case picks Laptop for one of two machines, checks that only that machine's project subtitle glyph changes, then hides machine names and checks the glyphs stay without the text.

  • The repository checkout menus are covered by the owner test only, not in a browser.

  • The browser case was only run against the fix. It depends on the new testID, so it has no separate RED; the RED evidence is the owner test above.

  • Hosted CI (CI — Tests) passed on this head on attempt 2. Attempt 1 had two unrelated failures, so failed jobs were rerun once:

    • Typecheck: the runner ran out of disk during Setup Node, before any repository code ran.
    • UI unit shard 29/32: sync.sessionOrganizationWarmCache.test.ts hit the default 1 s vi.waitFor limit at 1007 ms. That file is not touched here, and it passes locally on this head.
  • Copilot review did not arrive within 15 minutes of marking the PR ready. No review threads were opened.

Full UI suites were not run; hosted CI owns them.

Scope and deferrals

  • 0.3 port disposition is blocked because the destination checkout is absent.
  • Native QA deferred: native macOS multi-machine customization, reset and restart acceptance remain open.
  • The foreign-Home live Chrome proof remains blocked on the setup delay recorded in the ticket. Foreign-Home scoping here is covered by the owner test only.
  • Not changed: the session info machine link opens the machine page without serverId.
  • Not changed: on native, a session row's accessibility label drops the machine name when card labels are hidden.

Tracks OH-47.

…(OH-47)

Project headers named the machine in text only, so a machine's chosen icon
and color never reached the grouped session list. Render the shared
MachineDisplayGlyph for the machine the subtitle names, scoped to its Home.
The synthetic unknown machine stays text-only.
…(OH-47)

Project headers dropped the glyph along with the machine name, and neither
reached assistive technology. Render the shared SessionMachineIdentity so the
glyph stays when names are hidden, and add the name to the header's label.
Turning off machine identity on rows as well removes the glyph.

Repository checkout menus now show each machine's glyph, so checkouts with
the same label and path stay distinct.
@andorcassian
andorcassian marked this pull request as ready for review November 4, 2026 18:36
@andorcassian
andorcassian merged commit 6270a28 into dev Nov 4, 2026
83 of 88 checks passed
@andorcassian
andorcassian deleted the feature/OH-47-project-header-machine-glyph branch November 4, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant