Skip to content

fix(ui): tell users how to get host metrics on unsupported machines (OH-59) - #17

Merged
andorcassian merged 2 commits into
devfrom
feature/OH-59-host-metrics-cli-copy
Nov 4, 2026
Merged

andorcassian merged 2 commits into
devfrom
feature/OH-59-host-metrics-cli-copy

Conversation

@andorcassian

@andorcassian andorcassian commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

What changes

The Machines sidebar told users an online machine "does not support host metrics" and offered no next step. That message now states the cause and the action, in all 12 locales:

This machine CLI does not support host metrics. Released CLIs don't include them, so updating the app or CLI won't add them. Install the fork CLI on this machine, then restart its daemon.

This is copy only. The machineMonitoring.olderCli value changes; collection, transport, polling and row logic do not. The App guide's Machine monitoring section says the same thing.

  • The copy names the fork CLI because no released CLI has the metrics producer, so happier self update cannot help.
  • The copy names the daemon restart because the producer is registered on the daemon's machine RPC, and a running daemon replaces itself only when the CLI version changes. A fork CLI can have the same version as a release, so installing it does not replace the daemon.
  • The original first sentence stays, so the row still leads with the same state.
  • On a narrow sidebar the one-line summary truncates the message. The full text is in the expanded row and the accessibility label, which is the ticket's rule for truncated summary content. Tests now cover both.

Validation

  • Copy-only, so the repo rules need no RED. The test changes are test-only.
  • The unit test keys the unsupported state to t('machineMonitoring.olderCli') rather than English prose, so rewording does not fail it. The browser spec's added assertion on the action wording is removed; the spec still matches the unchanged first sentence.
  • MachineMonitoringSection.test.tsx now requires the message inside the expanded row. Deleting that row's state line fails 1 of its 3 tests; the line was then restored.
  • On the committed bytes: owner test plus locale audits (i18n.integrity, i18n, localeLiterals, localeLiterals.doNotTranslate), 5 files, 28 tests pass. apps/ui and packages/tests typechecks pass.
  • Docs check:content passes.
  • machines.monitoring.oh59.spec.ts, whole spec in Chrome on the same copy and spec bytes: 3 passed in 8.2 minutes, including the 180-second refresh and GPU tests. It now also expands the unsupported row at light, dark and 200% font scale. Screenshots show the full message at 1x; at 200% it scrolls within the Machines section.
  • The latest stable CLI tag, cli-v0.2.20, has no machine metrics capability (toolMachineMetrics.ts is absent), which supports the "Released CLIs" wording.
  • Not run: full suites.
  • The non-English translations were written by hand and have not had native-speaker review.

Scope and deferrals

  • 0.3 port disposition is blocked because the destination checkout is absent.
  • Native QA is deferred.
  • The copy says "released CLIs", so it must change if a release ever ships the metrics producer.
  • The row has no link to the guide. That would be new row behavior, not a copy change.
  • Activating a metrics-capable CLI on daily daemons is a separate decision and is not part of this PR, so real readings from installed hosts remain unverified. OH-59 stays open for that.

Tracks OH-59.

…OH-59)

The machine monitoring row stopped at "does not support host metrics", so
an online machine showed dashes with no next step. Add the action to the
existing copy in all 12 locales: run a metrics-capable CLI on that machine.
It also says an app update alone will not help, because the producer lives
in the host CLI.
…start (OH-59)

The previous action ("run a metrics-capable CLI") did not say which CLI or
that the daemon must restart. No released CLI ships the host metrics
producer, and the producer is registered on the daemon's machine RPC; a
running daemon only replaces itself when the CLI version changes. The copy
now says released CLIs lack the metrics, and to install the fork CLI and
restart that machine's daemon, in all 12 locales and the App guide.

Tests key the unsupported state to the translation value instead of English
prose, and cover the message inside the expanded row in the owner test and
the browser spec.
@andorcassian
andorcassian marked this pull request as ready for review November 4, 2026 20:26
@andorcassian
andorcassian merged commit 32b2ff4 into dev Nov 4, 2026
86 of 88 checks passed
@andorcassian
andorcassian deleted the feature/OH-59-host-metrics-cli-copy branch November 4, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant