Repository navigation
fix(ui): tell users how to get host metrics on unsupported machines (OH-59) - #17
Merged
Merged
Conversation
…OH-59) The machine monitoring row stopped at "does not support host metrics", so an online machine showed dashes with no next step. Add the action to the existing copy in all 12 locales: run a metrics-capable CLI on that machine. It also says an app update alone will not help, because the producer lives in the host CLI.
…start (OH-59)
The previous action ("run a metrics-capable CLI") did not say which CLI or
that the daemon must restart. No released CLI ships the host metrics
producer, and the producer is registered on the daemon's machine RPC; a
running daemon only replaces itself when the CLI version changes. The copy
now says released CLIs lack the metrics, and to install the fork CLI and
restart that machine's daemon, in all 12 locales and the App guide.
Tests key the unsupported state to the translation value instead of English
prose, and cover the message inside the expanded row in the owner test and
the browser spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Machines sidebar told users an online machine "does not support host metrics" and offered no next step. That message now states the cause and the action, in all 12 locales:
This is copy only. The
machineMonitoring.olderClivalue changes; collection, transport, polling and row logic do not. The App guide's Machine monitoring section says the same thing.happier self updatecannot help.Validation
t('machineMonitoring.olderCli')rather than English prose, so rewording does not fail it. The browser spec's added assertion on the action wording is removed; the spec still matches the unchanged first sentence.MachineMonitoringSection.test.tsxnow requires the message inside the expanded row. Deleting that row's state line fails 1 of its 3 tests; the line was then restored.i18n.integrity,i18n,localeLiterals,localeLiterals.doNotTranslate), 5 files, 28 tests pass.apps/uiandpackages/teststypechecks pass.check:contentpasses.machines.monitoring.oh59.spec.ts, whole spec in Chrome on the same copy and spec bytes: 3 passed in 8.2 minutes, including the 180-second refresh and GPU tests. It now also expands the unsupported row at light, dark and 200% font scale. Screenshots show the full message at 1x; at 200% it scrolls within the Machines section.cli-v0.2.20, has no machine metrics capability (toolMachineMetrics.tsis absent), which supports the "Released CLIs" wording.Scope and deferrals
Tracks OH-59.