Skip to content

Safely handle window split toggle on scrolling workspace layout (#14866) - #14867

Closed
Sebo1411 wants to merge 1 commit into
omacom:quattrofrom
Sebo1411:fix/issue-14866-toggle-window-split-scrolling-layout
Closed

Sebo1411 wants to merge 1 commit into
omacom:quattrofrom
Sebo1411:fix/issue-14866-toggle-window-split-scrolling-layout

Conversation

@Sebo1411

Copy link
Copy Markdown
Contributor

Fixes #14866

Changes

  • Introduces omarchy-hyprland-window-split-toggle to query the active workspace layout before dispatching togglesplit
  • If the current workspace is on the scrolling layout (or any layout other than dwindle), silently no-ops instead of raising a Lua runtime error dialog
  • Updates SUPER + J binding in default/hypr/bindings/tiling.lua to use the new helper
  • Adds test coverage in test/shell.d/hyprland-window-test.sh

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge; the previous unknown-layout issue is fixed, and no new actionable issue was found.

Summary

Adds a helper that sends togglesplit only when the active workspace reports dwindle.

  • SUPER + J toggles splits only on dwindle workspaces.

Reviews (2) · Last reviewed commit: "Safely handle window split toggle on scr..." · Reviewed by Greptile

Comment thread bin/omarchy-hyprland-window-split-toggle Outdated
@jandrusk

Copy link
Copy Markdown

Thanks! This overlaps two older open PRs for the same bug (#7556): #11863 and #6924. #11863 handles it inside the Lua binding instead of spawning a script on every keypress, and also covers the case this misses. hyprctl activeworkspace reports the regular workspace even when a special workspace (scratchpad) is shown, so a scrolling special workspace over a dwindle one would still hit the error. hl.get_active_special_workspace() or hl.get_active_workspace() handles that. Might be worth consolidating with #11863.

@Sebo1411

Copy link
Copy Markdown
Contributor Author

Closing in favor of #11863, which resolves this directly in the Lua binding and correctly accounts for special workspaces.

@Sebo1411 Sebo1411 closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SUPER+J (Toggle window split) raises "Runtime error in Lua: no such layoutmsg for scrolling" on scrolling-layout workspaces

2 participants