Skip to content

Floor Apple Silicon top bars to the camera notch cutout - #13641

Closed
AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-apple-notch-e0d3
Closed

AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-apple-notch-e0d3

Conversation

@AnPod

@AnPod AnPod commented Sep 28, 2026

Copy link
Copy Markdown

Summary

Fixes #13058

Top bars on Asahi laptops did not reserve the camera notch cutout, so center widgets could sit under the housing.

Change

  • Floor top-bar height to the measured notch cutout (incl. MBP 16″ → 32 logical px)
  • Accept calibrated [bar] notch-height
  • Migrate Apple Silicon layouts so center widgets stay clear of the housing

Test plan

  • bash test/shell.d/bar-notch-test.sh

@llstrk

llstrk commented Sep 29, 2026

Copy link
Copy Markdown

Automated duplicate check

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Possible duplicate: the 129 lines this PR adds are the same as in #13478, an open PR by the same author from 2026-09-27. Because of that, this PR was not reviewed separately. Closing one of the two would leave maintainers a single PR to review.


Opt out: To stop receiving these reviews, reply to this comment saying so.

Port the notch height stack so top bars reserve the measured camera cutout
on Asahi laptops, accept a calibrated [bar] notch-height override, and migrate
Apple Silicon layouts to keep center widgets off the housing.

Fixes omacom#13058

Co-authored-by: AnPod <AnPod@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/fix-apple-notch-e0d3 branch from 8249e4f to e90d1c6 Compare September 29, 2026 21:12
@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 3, 2026
@jandrusk

jandrusk commented Oct 7, 2026

Copy link
Copy Markdown

Heads-up for whoever picks this up: this PR's diff is byte-for-byte the same as #13478 (same author, a day older), including migrations/1789123456.sh, so only one of the two should stay open.

Both now also overlap #14431, the carried-forward Mac convergence PR (successor to #13362, which closed today). It adds its own bin/omarchy-hw-apple-silicon (delegating to omarchy-hw-platform) and its own [bar] notch-height / cutout handling in Style.qml, Bar.qml and BarModel.js, so these will conflict file for file. I'd suggest closing this one as a duplicate of #13478 and checking whether #14431 already covers #13058 before reviving either.

Two small things if it does go ahead: migrations/1789123456.sh is committed as 0755 (migrations are expected to be 0644), and the id looks hand-picked rather than generated with omarchy-dev-add-migration.

@omarchybot

Copy link
Copy Markdown
Collaborator

Closing this as a duplicate of #13478. Both are open against quattro, both are yours, and gh pr diff for the two is byte-for-byte identical: the same bin/omarchy-hw-apple-silicon, the same migrations/1789123456.sh, and the same changes to Style.qml, Bar.qml, BarModel.js and test/shell.d/bar-notch-test.sh. #13478 is a day older, so it keeps the review and this one closes; nothing here is lost.

Compared by Claude Opus 5.5, and Codex Medium, asked separately from the two diffs alone, agreed they are the same change. Nothing was run, since closing a copy needs no test; the fix itself will be reviewed on #13478. If they are meant to differ in a way the diffs don't show, say so and this can be reopened.

@omarchybot omarchybot added the duplicate This issue or pull request already exists label Oct 7, 2026
@omarchybot omarchybot closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything! duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apple Silicon regression: top bar no longer reserves the camera notch

5 participants