Preserve bar widgets when the layout changes - #10931
Open
kristofferR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving a bar widget rebuilds the module Repeaters, briefly blanking icons and resetting unrelated widget state.
Reconcile
ListModelentries in place so insertion, removal, reordering and settings edits preserve surviving widgets within each bar list. Match unchanged entries first to distinguish repeated widget IDs, and keep settings in a JSON string role so nested objects and arrays retain their normal shape. This also replaces the separate settings-only update path.Validated with the bar tests, widget contracts, icon geometry and text-colour tests, plus a QML runtime test that checks delegate identity and nested settings through layout edits. Local CodeRabbit preflight returned no findings. The focused tests also pass after rebasing onto the latest
quattro.The recordings show real desktop drags into and out of a group. The after recording also includes the Groups fixes for its own delegates, host handoff and hover icon.
After screen recording