Skip to content

fix: clear setgid bit from Windows VM mount sources - #10906

Open
SilentTearsDev wants to merge 1 commit into
omacom:quattrofrom
SilentTearsDev:fix/windows-vm-setgid
Open

fix: clear setgid bit from Windows VM mount sources#10906
SilentTearsDev wants to merge 1 commit into
omacom:quattrofrom
SilentTearsDev:fix/windows-vm-setgid

Conversation

@SilentTearsDev

Copy link
Copy Markdown

Problem

The Windows VM shared directories can end up with the setgid bit set after running the VM.

For example:

~/Windows -> 2700

The Windows VM permission validation expects 700, causing subsequent VM starts to fail until the setgid bit is manually removed with:

chmod g-s ~/Windows

Fix

Use an explicit 00700 mode when hardening the Windows VM mount source directories so that special permission bits such as setgid are cleared.

Also provide a useful error message when the resulting permissions are unexpected.

Testing

bash -n bin/omarchy-windows-vm
git diff --check
  • Reproduced the issue with ~/Windows having mode 2700
  • Verified that 00700 clears the setgid bit and results in 700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant