fix: clear setgid bit from Windows VM mount sources - #10906
Open
SilentTearsDev wants to merge 1 commit into
Open
fix: clear setgid bit from Windows VM mount sources#10906SilentTearsDev wants to merge 1 commit into
SilentTearsDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows VM shared directories can end up with the setgid bit set after running the VM.
For example:
The Windows VM permission validation expects
700, causing subsequent VM starts to fail until the setgid bit is manually removed with:chmod g-s ~/WindowsFix
Use an explicit
00700mode when hardening the Windows VM mount source directories so that special permission bits such as setgid are cleared.Also provide a useful error message when the resulting permissions are unexpected.
Testing
~/Windowshaving mode270000700clears the setgid bit and results in700