Bound running browser policy refreshes - #10899
Open
Drecullith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Chromium-family policy refreshes from blocking theme changes or Omarchy updates indefinitely.
omarchy-theme-set-browserrefreshes the platform policy of each running Chromium-family browser after writing the theme policy:"$command" --refresh-platform-policy --no-startup-windowThat invocation is currently unbounded.
On the affected system, a genuinely running Chromium instance did not hand the refresh request to the existing browser and exit. Instead, the command started another long-lived browser process and never returned. Because
omarchy-theme-set-browseris reached from theme refresh migrations, this can leaveomarchy updatepermanently stuck waiting for the browser.This change treats the live refresh as the best-effort operation it is:
timeout --kill-afterpattern so a process that ignores TERM cannot remain stuck indefinitely;The browser refresh now runs as:
No updater signal-trap changes are included. The issue reporter's follow-up testing retracted that separate suggestion; the bounded browser invocation is sufficient for the hang addressed here.
Fixes #10636.
Tests
Added
test/shell.d/theme-browser-refresh-test.shcovering:The focused regression test passes.
Also verified:
bash -n bin/omarchy-theme-set-browserbash -n test/shell.d/theme-browser-refresh-test.sh