Classify T2 built-in trackpads as internal - #10890
Open
Drecullith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
disable_while_typingon T2 MacBooks by marking Apple's built-in trackpad as an internal touchpad in the systemd hardware database.On T2 machines, the internal keyboard/trackpad is exposed through the
t2bce_vhcivirtual USB controller. That makes the built-in trackpad appear removable/external to libinput, so its disable-while-typing feature is unavailable even when Hyprland hasinput:touchpad:disable_while_typingenabled.This change adds a narrowly scoped hwdb override:
Apple Inc. Apple Internal Keyboard / Trackpaddevice name;ID_INPUT_TOUCHPAD_INTEGRATION=internal;Fresh T2 installs deploy and compile the rule through the existing
fix-t2.shhardware path.A new migration applies the same rule to existing T2 installations, using the same T2 PCI detection already used by Omarchy's T2 setup. The migration only recompiles the hwdb when the installed rule differs from the shipped rule, making it idempotent.
The input-device retrigger is best-effort: if a live retrigger fails, the compiled hwdb remains installed and will apply on the next device enumeration or reboot.
Fixes #10815.
Tests
Added
test/shell.d/t2-trackpad-test.shcovering:05ac:027binternal trackpad is classified as internal;05ac:027e, is also classified as internal;The focused regression suite passes 6/6.
Also verified:
bash -n install/hardware/apple/fix-t2.shbash -n migrations/1788912000.shbash -n test/shell.d/t2-trackpad-test.shsystemd-hwdb --strictNo physical T2 MacBook was available for live hardware verification. The issue reporter independently confirmed that setting
ID_INPUT_TOUCHPAD_INTEGRATION=internalfixes disable-while-typing on the affected machine.