Repair T1 Mac PCIe hotplug defaults - #10886
Open
Drecullith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair existing T1 Mac installations whose Limine configuration still contains
pcie_ports=compat.The earlier T2 migration replaces this parameter with:
pm_async=off mem_sleep_default=deepbut it is gated specifically on T2 hardware and operates on
t2-mac.conf. Existing T1 MacBook installations can instead retain/etc/limine-entry-tool.d/macbook-t1.confwith the obsoletepcie_ports=compatsetting.On affected machines, that setting disables native PCIe hotplug and can prevent PCIe-tunneled devices behind a Thunderbolt dock from appearing even though the dock itself is authorized and DisplayPort passthrough works.
This adds a new migration rather than modifying the previous T2 migration, since systems that already completed that migration would not rerun it.
The new migration:
macbook-t1.confexists;pcie_ports=compat;Fixes #10638.
Tests
Added
test/shell.d/t1-pcie-hotplug-test.shcovering:pcie_ports=compatis removed;macbook-t1.confare skipped;Focused regression suite: 5/5 passing.
Also verified:
bash -n migrations/1788906000.shbash -n test/shell.d/t1-pcie-hotplug-test.shNo physical T1 MacBook hardware was available for live verification. The issue reporter independently reports successful recovery after applying the equivalent kernel-command-line change and rebuilding Limine.