rtl: Add missing reset to PC carry-in flops - #172
Open
devtyagi3909 wants to merge 1 commit into
Open
Conversation
Fixes olofk#151. The registers `pc_plus_offset_cy_r` and `pc_plus_4_cy_r` are used in carry feedback paths. Without an explicit reset, they propagate `X` states during the first cycle of computation in gate-level simulations. This commit explicitly zeros them based on the `RESET_STRATEGY` parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151.
The registers
pc_plus_offset_cy_randpc_plus_4_cy_rare used in carry feedback paths. Without an explicit reset, they propagateXstates during the first cycle of computation in gate-level simulations.This PR explicitly zeros them during reset (and via
initialblock whenRESET_STRATEGY == "NONE"), preventing undefined behavior on startup.