Repository navigation
Show negative stuns as zero on the match page - #3396
Merged
Merged
Conversation
The stun counter read from the replay can go below zero (odota#2870, odota#2613). The API keeps that value as it is in the replay, and the match page now shows it as 0: the performances cell, its team total and bars, and the stuns line of the fantasy points.
howardchung
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the stun counter in the replay can go below zero, which is what #2870 and #2613 show (-0.66 for the pangolier in 6270285586, -0.23 for the bounty hunter in #2613's match). per the discussion in #2870 the api keeps the value as it is in the replay, and this only changes what the match page shows:
player pages (records, histograms, trends) aggregate on the server, so they're left as they are.
before / after on 6270285586.
performances, before:
after:
fantasy, before:
after:
build and typecheck pass, testcafe 74 passed.
Closes #2870
Closes #2613