Repository navigation
Show gold fed in the deaths table - #3395
Merged
Merged
Conversation
odota/parser#93 added gold_fed to each deaths_log entry: the gold the enemy team was paid for that death, killer and assisters together. This adds it as a column next to Gold Lost, and as a line in each death's tooltip. Entries with gold_fed_shared split one payout with another death in the same second, so one of them can read 0. Their tooltip says so instead of showing a bare 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odota/parser#93 added
gold_fedto eachdeaths_logentry, the gold the enemy team was paid for that death, killer and assisters together. this shows it in the deaths table on the combat tab, for odota/core#1511.entries with
gold_fed_sharedsplit one payout with another death in the same second, so one of the two can read 0. their tooltip says "split with another death in the same second" so the 0 doesn't look like a bug.the team totals match the enemy's
gold_reasons["12"]on 95 of 96 sides from recently parsed matches. the one that doesn't is 9026727829, radiant, short by 600. that comes from the data, not this change, since the column just sumsdeaths_log.before / after on 9026731311.
before:
after:
build and typecheck pass, testcafe 74 passed.