Repository navigation
Fail the tests when a page renders nothing - #3391
Merged
Merged
Conversation
howardchung
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces the blanket
--skip-js-errorswith a per fixture filter forFailed to fetch, which is the one the request hooks provoke, and gives each test a chance to actually load before checking that something rendered.on a build with the
Percent.tsxbreakage from #3384: 1/74 fails withnothing rendered into #root. on master: 74 passed.the run goes from about 44s to 1m14s at concurrency 4. the 3 second wait is arbitrary and machine dependent, and this only catches a page that renders nothing at all, not a component that renders wrong without throwing. happy to tune or drop the wait if you'd rather trade the coverage back.
Closes #3390