Skip to content

Revert "Add per-minute records to the player Records page" #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howardchung merged 1 commit into from
Sep 20, 2026
Merged

Revert "Add per-minute records to the player Records page" #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions src/actions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ import { langs } from "../lang";
import config from "../config";
import { paramsWithTurbo } from "../utility";
import transformHeroItemSuggestion from "./transformHeroItemSuggestion";
import {
isPerMinuteRecord,
perMinuteRecordParams,
transformPerMinuteRecords,
} from "./perMinuteRecords";

export const getMetadata = () =>
action("metadata", config.VITE_API_HOST, "api/metadata");
Expand Down Expand Up @@ -198,20 +193,12 @@ export const getPlayerRecords = (
params: any,
field: string,
) =>
isPerMinuteRecord(field)
? action(
"playerRecords",
config.VITE_API_HOST,
`api/players/${accountId}/matches`,
{ ...paramsWithTurbo(params), ...perMinuteRecordParams(field) },
transformPerMinuteRecords(field),
)
: action(
"playerRecords",
config.VITE_API_HOST,
`api/players/${accountId}/matches`,
{ ...paramsWithTurbo(params), sort: field, limit: 20 },
);
action(
"playerRecords",
config.VITE_API_HOST,
`api/players/${accountId}/matches`,
{ ...paramsWithTurbo(params), sort: field, limit: 20 },
);
export const getPlayerTrends = (
accountId: string,
params: any,
Expand Down
45 changes: 0 additions & 45 deletions src/actions/perMinuteRecords.ts
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions src/components/Player/Pages/Records/Records.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ import { getPlayerRecords } from "../../../../actions";
import Table from "../../../Table/Table";
import Container from "../../../Container/Container";
import dataColumns from "../matchDataColumns";
import { perMinuteRecords } from "../../../../actions/perMinuteRecords";
import ButtonGarden from "../../../ButtonGarden/ButtonGarden";
import playerRecordsColumns from "./playerRecordsColumns";
import useStrings from "../../../../hooks/useStrings.hook";

const excludedColumns = ["win_rate", "level"];
const recordsColumns = dataColumns
.filter((col) => !excludedColumns.includes(col))
.concat(perMinuteRecords);
const recordsColumns = dataColumns.filter(
(col) => !excludedColumns.includes(col),
);

const Records = ({
routeParams,
Expand Down
3 changes: 0 additions & 3 deletions src/lang/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,6 @@
"heading_kda": "KLA",
"heading_gold_per_min": "Gold Per Min",
"heading_xp_per_min": "XP Per Min",
"heading_kills_per_min": "Kills Per Min",
"heading_hero_damage_per_min": "Hero Damage Per Min",
"heading_tower_damage_per_min": "Tower Damage Per Min",
"heading_denies": "Denies",
"heading_lane_efficiency_pct": "EFF@10",
"heading_duration": "Duration",
Expand Down
Loading