Skip to content

Add per-minute records to the player Records page - #3383

Open
Xvie wants to merge 1 commit into
odota:masterfrom
Xvie:feat/per-minute-records
Open

Xvie wants to merge 1 commit into
odota:masterfrom
Xvie:feat/per-minute-records

Conversation

@Xvie

@Xvie Xvie commented Sep 11, 2026

Copy link
Copy Markdown

Adds Kills Per Min, Hero Damage Per Min and Tower Damage Per Min to the player Records page, so a long game no longer takes every damage record by default. In the screenshot the 22 minute Phantom Assassin game outranks a 62 minute Invoker game that has more than twice the absolute hero damage.

Depends on odota/core#2983 — those sort fields don't exist in the API yet, so the column stays blank until that ships.

Kept in a separate export from the default matchDataColumns list rather than added to it, since Histograms.tsx and Trends.tsx import the same default. The th_ strings already existed from the benchmarks work, so only the three heading_ button labels are new.

Ideally these would just go in the shared list and work everywhere, and Trends would in fact work as-is once odota/core#2983 lands, since it projects the field rather than hitting a whitelist. The blocker is histograms: bucketSize is Math.ceil((max + 1) / buckets), so the width can never drop below 1, and kills_per_min has a whole range under 1 — on a real 975 match account it puts 974 matches in bucket 0 and 1 in bucket 1. kda only escapes this because its range is large. Serving these from /histograms needs fractional bucket widths without changing how the existing integer fields bucket, which felt like its own change rather than something to bundle here. Happy to follow up with it, and the separate export goes away when that lands.

npm run build passes. I couldn't run npm test locally — testcafe/testsUtility.ts targets port 5000, which macOS AirPlay Receiver occupies on my machine.

per-minute records

Adds Kills Per Min, Hero Damage Per Min and Tower Damage Per Min buttons.
Kept in a separate export from the shared match data columns so the
Histograms and Trends pages, which import the same list, don't gain buttons
the histograms endpoint can't serve.

Requires the matching API support for per-minute sort fields.
@Xvie
Xvie force-pushed the feat/per-minute-records branch from 716905f to 2ed195a Compare September 11, 2026 09:16
@Xvie
Xvie marked this pull request as ready for review September 11, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant