Show the actual first blood victim on the Timeline - #3374
Draft
geracosta wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Timeline guesses the first blood victim from the killer's first kills_log entry. That misses first bloods that aren't credited to a hero: in the replay from odota/core#1488 a creep landed the blow, so the tooltip shows no victim at all. With
victim_player_slotfrom odota/core#2976 it can just look the victim up, and kills_log stays as the fallback for matches without the field.The screenshot is that exact replay, parsed locally: the marker now names the Drow.
Draft until the core side lands.