Skip to content

Show smoke icon on smoked kills in match log #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geracosta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show smoke icon on smoked kills in match log #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/Match/MatchLog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
import FormField from "../Form/FormField";
import { StyledLogFilterForm } from "./StyledMatch";
import HeroImage from "../Visualizations/HeroImage";
import config from "../../config";
import sword from "../Icons/Sword.svg";
import { IconBloodDrop, IconRoshan } from "../Icons";
import lightning from "../Icons/Lightning.svg";
Expand Down Expand Up @@ -502,6 +503,15 @@ function EntryMessage({ entry, strings }: { entry: any; strings: Strings }) {
<span className="smallMutedText">{strings.killed}</span>
<HeroImage id={hero.id} className="detailIcon" isIcon />
<span className="smallBoldText">{hero.localized_name}</span>
{entry.smoke && (
<Tooltip title={strings.smoke_kill}>
<img
src={`${config.VITE_IMAGE_CDN}/apps/dota2/images/dota_react/items/smoke_of_deceit.png`}
alt={strings.smoke_kill}
className="detailIcon"
/>
</Tooltip>
)}
</>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/lang/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,7 @@
"killed": "killed",
"team_courier": "{team}'s courier",
"slain_roshan": "Have slain Roshan",
"smoke_kill": "Kill from Smoke of Deceit",
"destroyed_tormentor": "Have destroyed the Tormentor",
"drew_first_blood": "Drew First Blood",
"player_profile_private_title": "This profile is private",
Expand Down