Add deaths summary table to Combat tab - #3368
Conversation
2b729dd to
3a0e289
Compare
| height: 29px; | ||
| } | ||
| `; | ||
| export const StyledDeathsSummary = styled.div` |
There was a problem hiding this comment.
Ideally we move away from styled-components for new code. I think we're trying to replace it with css modules
There was a problem hiding this comment.
happy to, but i'd rather not set the pattern from a feature PR. there's no .module.css in the repo yet and the README still lists styled-components, so whatever i write here becomes the convention by default.
what stopped me is constants.ts. these styles use colorMutedLight and a css module can't read it, so converting means hardcoding rgba(255, 255, 255, 0.6) in the file.
i wrote up the longer version in #3072 along with what's changed since you opened it. would rather settle it there and keep this PR consistent with the rest of the Match components. if you'd still prefer the css module here i'll just do it.
2 participants
Adds a per-team Deaths table to the Combat tab, built from the
deaths_logfield proposed in odota/parser#88: deaths, gold lost and time dead per player with totals, plus a per-death breakdown of who killed them and when (gold lost and time dead in the tooltip). This is the death summary that was asked for in odota/core#1465.The table only renders when the match has
deaths_log, so nothing changes for matches parsed before that field exists.Screenshot from a local run (match 8754463676, parsed with the parser branch and injected into the dev server):
The tooltip in the shot is the illusion kill fixed in odota/parser#90, showing the 480 gold and 22s it cost.
Draft until parser#88 lands.