Add deaths summary table to Combat tab - #3368
Draft
geracosta wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a per-team Deaths table to the Combat tab, built from the
deaths_logfield proposed in odota/parser#88: deaths, gold lost and time dead per player with totals, plus a per-death breakdown of who killed them and when (gold lost and time dead in the tooltip). This is the death summary that was asked for in odota/core#1465.The table only renders when the match has
deaths_log, so nothing changes for matches parsed before that field exists.Screenshot from a local run (match 8754463676, parsed with the parser branch and injected into the dev server):
The tooltip in the shot is the illusion kill fixed in odota/parser#90, showing the 480 gold and 22s it cost.
Draft until parser#88 lands.