Fix edit losing the typed secret, and recipients with a trailing newline - #19
Merged
Conversation
edit checked nothing about the destination until after the editor had closed, and removed the plaintext on the way out, so writing into a directory that does not exist threw away what had just been typed. Fresh repositories have no secretsDir, which makes the very first secret the one most likely to be lost. Create the directory before the editor runs, and replace the file by rename so a write that fails partway cannot take the previous ciphertext with it.
`kix.hostPubkey = ./secrets/host.pub` hands the file's contents to the parser as they are. agessh tolerates the trailing newline and age's own parser does not, so an age host key failed where an SSH one worked, and only in seal, after the identity had already been unlocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.