-
Notifications
You must be signed in to change notification settings - Fork 187
feat: support templating in extraInitContainers #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||
| name: oauth2-proxy | ||||||
| version: 10.3.0 | ||||||
| version: 10.3.1 | ||||||
| apiVersion: v2 | ||||||
| appVersion: 7.15.0 | ||||||
| home: https://oauth2-proxy.github.io/oauth2-proxy/ | ||||||
|
|
@@ -30,8 +30,8 @@ maintainers: | |||||
| kubeVersion: ">=1.16.0-0" | ||||||
| annotations: | ||||||
| artifacthub.io/changes: | | ||||||
| - kind: added | ||||||
| description: Add tpl support for config.cookieName, config.existingSecret, customLabels, image.registry, imagePullSecrets, and networkPolicy.ingress/egress | ||||||
| - kind: changed | ||||||
|
||||||
| - kind: changed | |
| - kind: added |
Copilot
AI
Mar 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds templating support for the existing extraInitContainers value, but the user-facing docs don’t mention that extraInitContainers now supports tpl (unlike extraEnv, which is documented in the chart README). Please update the chart documentation (README and/or the values.yaml comments) to reflect the new templating behavior and any gotchas (e.g., {{ ... }} sequences will now be evaluated).
| description: feat: support templating in extraInitContainers | |
| description: feat: support templating in extraInitContainers (values are now rendered with tpl, so {{ ... }} sequences will be evaluated as Helm templates rather than treated as literal text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chart version bump looks like a SemVer patch (10.3.0 -> 10.3.1), but this PR introduces new functionality (templating support in
extraInitContainers). Per SemVer and the repo's versioning guidance, consider bumping the minor version instead (or clarify why this is treated as a patch-level change).