Skip to content

update position before firing onChange #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CVChrisWilson wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update position before firing onChange #109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a6647d
Update location on drop(trash)
CVChrisWilson Oct 6, 2015
33eed2c
update position before onChange
CVChrisWilson Oct 7, 2015
b8e9792
FEN return fix
CVChrisWilson Oct 7, 2015
81f191f
Update chessboard.js
Oct 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions www/js/chessboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,14 +1023,15 @@ function setCurrentPosition(position) {
// do nothing if no change in position
if (oldFen === newFen) return;

// update state
CURRENT_POSITION = position;

// run their onChange function
if (cfg.hasOwnProperty('onChange') === true &&
typeof cfg.onChange === 'function') {
cfg.onChange(oldPos, newPos);
}

// update state
CURRENT_POSITION = position;

}

function isXYOnSquare(x, y) {
Expand Down