test(request): reject duplicate singleton headers - #78
Merged
ronag merged 1 commit intoAug 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports upstream Undici test cases to ensure Client.request() rejects duplicate singleton headers (Host and Content-Length) when headers are provided as a flat array, and verifies the rejection happens before any connection attempt.
Changes:
- Added a shared helper to assert duplicate-header validation rejects and that no connector/network activity occurs.
- Added four new tests covering same-case and case-variant duplicates of
HostandContent-Lengthin flat header arrays.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ronag
marked this pull request as ready for review
August 30, 2026 06:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lower runtime already has the upstream rejection logic, so this is deliberately a test-only port.
Validation
Copilot reviewed the exact head commit with no actionable findings.