test: cover NaN request highWaterMark - #77
Merged
ronag merged 1 commit intoAug 30, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a missing regression assertion to the existing invalid highWaterMark test matrix to ensure highWaterMark: Number.NaN is rejected with the expected error, matching upstream coverage intent.
Changes:
- Extends the
invalid optstest to include ahighWaterMark: Number.NaNrequest case. - Updates the
tsplplan count to account for the additional assertions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ronag
marked this pull request as ready for review
August 30, 2026 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the missing regression assertion from nodejs/undici PR nodejs#5062.
The runtime Number.isFinite validation already exists in this fork. This PR adds the omitted Number.NaN callback case to the existing invalid highWaterMark matrix.
Validation so far: