test: cover synchronous connector throws - #76
Merged
ronag merged 2 commits intoAug 30, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Node.js-style regression coverage ensuring Client requests settle (don’t hang) when a custom connect implementation throws synchronously, and that the client can recover once the connector stops throwing.
Changes:
- Introduces a new node-test covering repeated request settlement when
connectthrows synchronously. - Adds a recovery regression asserting subsequent requests succeed once
connectstops throwing.
Suppressed comments (4)
test/node-test/client-connector-throw.js:17
- Use
t.after(...)for server cleanup to match the established node-test pattern in this repo and to ensure the hook is registered on the current test instance.
after(closeServerAsPromise(server))
test/node-test/client-connector-throw.js:25
- Use
t.after(...)for client cleanup to match the established node-test pattern in this repo and to ensure the hook is registered on the current test instance.
after(() => client.destroy())
test/node-test/client-connector-throw.js:48
- Use
t.after(...)for server cleanup to match the established node-test pattern in this repo and to ensure the hook is registered on the current test instance.
after(closeServerAsPromise(server))
test/node-test/client-connector-throw.js:64
- Use
t.after(...)for client cleanup to match the established node-test pattern in this repo and to ensure the hook is registered on the current test instance.
after(() => client.destroy())
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ronag
marked this pull request as ready for review
August 30, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the regressions from nodejs/undici PR nodejs#4834.
The lower fork already handles a synchronously throwing connector through its Promise-based connect path. These tests verify that repeated requests settle instead of hanging and that the client recovers once the connector stops throwing.
Validation so far: