test(readable): port setEncoding consume matrix - #73
Merged
ronag merged 2 commits intoAug 30, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds regression coverage around Readable/body-mixin consumption behavior when setEncoding() is applied before and during chunk arrival, specifically targeting multi-byte UTF-8 boundary cases and ensuring later .text()/.json()/etc consumption includes all buffered chunks.
Changes:
- Added new
Readableunit tests coveringsetEncoding()interactions across chunk boundaries (including partial UTF-8 decoder state) and verifying correctness acrossbytes(),arrayBuffer(),blob(),text(), andjson(). - Added a
Clientintegration regression test (nodejs#5611) to ensuresetEncoding('utf8')followed by deferred.text()consumption preserves a multi-chunk response body.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/readable.js | Adds regression tests for Readable body-mixin consumption with setEncoding() across chunk boundaries and multiple consumption methods. |
| test/client-request.js | Adds an integration regression test ensuring Client response bodies remain intact when setEncoding() is set before delayed .text() consumption. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…-set-encoding-20260829 * origin/master: fix(connect): preserve DNS origin hostname on sockets
ronag
marked this pull request as ready for review
August 30, 2026 06:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current lower-fork runtime already passes these cases, so this is intentionally a test-only PR.
Validation
Draft pending the full exact-head matrix and fresh Copilot review.