fix(concealer): apply correct extmark opts#1735
Open
austinliuigi wants to merge 2 commits into
Open
Conversation
…spacing before it
github-project-automation
Bot
moved this to added-updated-reopened
in sorting neorg issue tracker
Contributor
|
I think arguably the heading whitespace having the heading highlight is intentional/desirable. Can we make it configurable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the extmarks added by the concealer:
Demonstration of the wrapping issue: Notice how the extmarks stay on the left side of the screen even as the screen scrolls to the right. Also notice how the whitespace before the higher level headings has the heading highlight applied to it.
Before:
2025-09-10T17-33-16.mp4
After:
2025-09-10T17-37-47.mp4