fix(painter): don't re-use a bottom-flush prompt anchor after a scroll#1133
fix(painter): don't re-use a bottom-flush prompt anchor after a scroll#1133kronberger-droid wants to merge 2 commits into
Conversation
|
@kronberger-droid Thanks a lot for the quick fix, however it doesn't seem to fix my issue. I cherry-picked the change on an older pair of revs of nushell 8774a88a1 and reedline 0977032 (sadly current main branches cause me bigger troubles), and it acts exactly the same. |
|
Here're the minimal reproducible steps according to my test, but you'll have to test them on older revs as well.
|
|
thanks! I will check it out. This was just a guess since i could not fully understand what was happening in the video. |
8e96204 to
6de2bfa
Compare
6de2bfa to
eab2e25
Compare
|
@blindFS |
|
@kronberger-droid Thanks again! It works much better now. Nitpick: it clears the terminal on menu exit, better to keep it on the same line. I think it worked that way before, but I'm not very sure. |
|
@blindFS |
Screen.Recording.2026-07-24.at.8.17.58.PM.movProbably different to your description. |
|
@blindFS |
Oops, my bad, I missed a crucial part of your change, it works perfectly now. Thanks a lot! |
eab2e25 to
956680b
Compare
Summary
When an external completer scrolls the terminal (
fzf --heightwith little room below the prompt), the prompt landed in the wrong palce after the menu closed, since #1090 trusts aVerifiedanchor without re-querying and the completer path never marked it stale.Two commits:
re-anchor the prompt to the cursor after an external scroll
Activate/Edit/page re-queries the completer, mark the anchor stale so the next paint re-verifies it.But might be redundant depending on what comes out of the discussion in Weird regression on current main branch #1131.
don't re-use a bottom-flush prompt anchor after a scroll
ExecuteHostCommand):select_prompt_rowre-used a prompt range flush against the screen bottom and drew over scrolled-up output.