config: stop offering and writing engine settings nub does not consume - #811
Merged
Conversation
`aubeNoAutoInstall` gates the engine's own pre-run staleness check, in `commands::auto_install::ensure_installed` — reached only from the engine's `run` / `exec` / `restart`. None of those is an `ENGINE_VERB`: nub runs scripts through its own frontend and gates freshness in `verify_deps`. The setting therefore decided nothing under nub, yet `nub config set aubeNoAutoInstall true` wrote that key into the user's `.npmrc` and `nub config list --all` advertised it — nub putting the engine's brand in a user's config for a value nub never reads. The embedder profile gains `unsupported_settings`, pairing a canonical name with the "use this instead" line the engine cannot know. A listed setting is absent from `meta::find` / `meta::all`, which is what makes it unread: every generated `resolved::*` accessor opens with that lookup, so the whole source chain falls through to the default. Empty for standalone aube, so its lookups and enumerations are unchanged. The write path needed three guards, not one — `set_value`, the pnpm-incumbent `set_project_scalar_to_workspace_yaml` seam, and nub's own `classify_set` router plus its `--global` branch, which bypasses the router. `config set` is free-form by npm parity, so an unrecognized key is written verbatim; removing the setting from the table alone would have left every route still writing it. Also fixes the remote test job leaking `NUB_ALLOW_INCOMPLETE_RUNTIME` into `cargo test`, where it failed `brand_boundary_no_globals_no_env` and aborted the run at `tests/integration.rs` — so no remote `--job test` had ever reached the suites after it alphabetically.
Contributor
|
Your Claude subscription has hit its usage limit. It resets at 12:40am (UTC). Re-trigger Pullfrog after the reset, or add an Add repo secret → · Model settings → · Setup docs → · Ask in Discord →
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Shipped in v0.8.2: https://github.com/nubjs/nub/releases/tag/v0.8.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aubeNoAutoInstallgates the engine's pre-run staleness check, reached only from the engine'srun/exec/restart. None is anENGINE_VERB— nub runs scripts through its own frontend and gates freshness inverify_deps— so it decided nothing here, yetnub config set aubeNoAutoInstall truewrote that key to the user's.npmrcandconfig list --alladvertised it.The embedder profile gains
unsupported_settings. A listed setting is absent frommeta::find/meta::all, so every generated accessor falls through to the default, and all three write routes refuse it, pointing atverifyDeps/verify-deps-before-run. Empty for standalone aube.