-
Notifications
You must be signed in to change notification settings - Fork 60
aube: sync upstream v1.35.0 #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3d430a0
aube: sync upstream v1.35.0
colinhacks fbd40ff
linker: retire the #394 symlink override for native bin targets
colinhacks bedde94
Merge origin/main into aube-135
colinhacks b832ce5
aube: track upstream's GVS auto-disable list in the embedder-seam test
colinhacks 1f23a7a
tests(aube-bats): skip four update.bats tests aube v1.35.0 adds
colinhacks 63232cb
Merge origin/main into aube-135
colinhacks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub(crate)visibility is not the blocker. aube v1.35.0 already writes.modules.yamlitself with the settings-resolved store (install/gvs.rs::write_modules_metadata, called frominstall/finalize.rs:235whenever!virtual_store_only), and when the file is absent it writes a single-key pretty-printed JSON object — whichis_nub_modules_yamlaccepts as nub's own stub. Sincevite_compat::applyruns after the engine returns, nub does not merely fail to consult the resolver: it overwrites a correct value with the default one.Technical details