Skip to content

chore(i18n): Update englisg tooltip text for chart embedding url#3047

Closed
userquin wants to merge 1 commit into
mainfrom
userquin/i18n-change-trends-embedding-tip
Closed

chore(i18n): Update englisg tooltip text for chart embedding url#3047
userquin wants to merge 1 commit into
mainfrom
userquin/i18n-change-trends-embedding-tip

Conversation

@userquin

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

📚 Description

From this comment: #3040 (comment)

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 15, 2026 3:23pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Jul 15, 2026 3:23pm
npmx-lunaria Ignored Ignored Jul 15, 2026 3:23pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2e344c76-465e-4bbc-b6b2-56166e42c6a0

📥 Commits

Reviewing files that changed from the base of the PR and between 5bbce3e and e772e56.

📒 Files selected for processing (1)
  • i18n/locales/en.json

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Clarified the embed chart guidance for startDate and endDate URL parameters.
    • Noted that charts display the previous 12 months by default when these parameters are omitted.

Walkthrough

The English embed chart tip now explains that startDate and endDate URL parameters control the displayed range, with the graph defaulting to the last 12 months when they are absent.

Changes

Embed chart tip

Layer / File(s) Summary
Clarify embed chart date parameters
i18n/locales/en.json
The translation references startDate and endDate and documents the last-12-months default.

Possibly related PRs

  • npmx-dev/npmx.dev#3046: Updates the same embedded chart tip translation with equivalent date-parameter and default-range wording.

Suggested reviewers: graphieros, alexdln, 43081j

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change to the chart embed tooltip text.
Description check ✅ Passed The description is related to the tooltip text update and its source context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch userquin/i18n-change-trends-embedding-tip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@userquin

Copy link
Copy Markdown
Member Author

superseded by #3046

@userquin userquin closed this Jul 15, 2026
@userquin
userquin deleted the userquin/i18n-change-trends-embedding-tip branch July 15, 2026 15:24
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant