docs: clarify Demucs segment size help - #307
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. WalkthroughThe Demucs segment-size documentation now uses seconds, explains memory usage and the model-configured default, and replaces the invalid example. A unit test verifies consistency between CLI help and ChangesDemucs segment-size documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change clarifies Demucs segment-size guidance and keeps README and CLI help coverage aligned. No current merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #246.
The Demucs segment-size help now explains that values are seconds, identifies
Defaultas the model-configured length, and uses a valid40-second example. The README snapshot and argparse source are updated together, with a regression check covering both.Validation: all 550 unit tests pass (4 skipped); focused regression, compile, diff, and changed-hunk formatting checks pass. The repository's whole-file Black check remains noisy on the same two pre-existing files.
Summary by CodeRabbit
Documentation
Defaultuses the model-configured segment length.Tests