Rename/docs to output - #31
Merged
Merged
Conversation
Norbert pointed out the inconsistency: contentPath/dataPath/templatePath
all got their method names renamed to match the new content/data/
template folder scheme, but targetPath only had its default *value*
renamed (docs -> output in the previous commit), not the accessor itself.
Renamed targetPath/targetPath:/defaultTargetPath to outputPath/
outputPath:/defaultOutputPath throughout (FOWebSite, FOWebResource,
FOPublisher, and all call sites in tests) for full symmetry:
contentPath/dataPath/templatePath/outputPath.
FOPublisher's own defaultTargetPath value ('generated') stays as-is,
same reasoning as before - it's an independent default, not part of
this rename.
…page Found while verifying the data/series/<slug>.md feature against real content: blog/series/soil.html (the individual series overview page) never actually used FOSeries>>abstract at all - only blog/series/ index.html (the listing of all series) did. So a hand-written abstract only ever showed up in the site-wide series index, never on the series' own page, which is the more natural place a reader would expect to see it. FOSeries>>hasCustomAbstract exposes whether a data/series/<slug>.md actually exists (not just "abstract text is available", which is always true via the auto-derived fallback). FOSeriesOverviewBuilder>>buildPage now shows the abstract as a plain <p> intro before the list of post abstracts, but only when hasCustomAbstract - showing the auto-derived one unconditionally would just duplicate the first post's own text redundantly. Deliberately not using the templated 'series-abstract' listing entry (title+link+partCount) here - a self-referential link back to the very page you're on doesn't make sense outside a listing context. Verified against the real data/series/soil.md Norbert already wrote: now appears as the intro paragraph on blog/series/soil.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.