test: cover Node SEA compatibility - #123
Merged
Merged
Conversation
timfish
approved these changes
Jul 21, 2026
Contributor
Author
|
Just checking in on this one when you have a chance. No rush. |
jsumners-nr
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Node SEA does not provide
require.resolve. This has causedrequire-in-the-middleto fail while loading before.Add a regression test that loads
index.jswith a require function that has noresolveproperty. The test also creates aHook, hooks the builtinpathmodule, and unhooks it.The test uses
vmto reproduce the SEA-specific loader condition without adding a SEA build tool or changing the supported Node.js test matrix.Tests:
npm test