Repository navigation
Conversation
ToFFIArgument validated int32/uint32 with IsInt32()/IsUint32(), which reject -0, while every other integer width and the Fast API and SharedBuffer paths accept it. Use the same validators as the 8- and 16-bit branches so behavior no longer depends on the JIT tier. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67035 +/- ##
==========================================
- Coverage 90.65% 90.65% -0.01%
==========================================
Files 797 797
Lines 278268 278269 +1
Branches 53517 53509 -8
==========================================
- Hits 252269 252262 -7
+ Misses 16391 16386 -5
- Partials 9608 9621 +13
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Oct 27, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #67033
ToFFIArgumentvalidatedint32/uint32withIsInt32()/IsUint32(), which reject-0.This switches both branches to
GetValidatedSignedInt/GetValidatedUnsignedInt, the same validators the 8- and 16-bit branches use. Error codes and messages are unchanged.Assisted-by: claude:opus-5.5